[PATCH] samba-tool 'user create' examples incorrect

Michael Adam obnox at samba.org
Thu Jan 7 14:28:27 UTC 2016


On 2015-12-04 at 09:52 -0800, Jeremy Allison wrote:
> On Sat, Nov 21, 2015 at 09:27:04AM +0000, Rowland Penny wrote:
> > On 21/11/15 00:52, Michael Adam wrote:
> > >
> > >The intended change itself is good, but a few cosmetic comments:
> > >
> > >- The patch changes line breaks in several places
> > >   where no other change is done. Please avoid that.
> > >   If you want to fix the formatting of the text,
> > >   that should be a separate patch
> > >
> > >- In those places where you add line breaks,
> > >   you introduces some trailing spaces, which make
> > >   git am complain. Please avoid those:
> > > [...]
> > 
> > OK, new patch based on Michaels comments, just changed 'add' to 'create'
> > 
> > Rowland
> 
> Sorry for the delay Rowland - pushed !

Gosh, I remembered there was s/th I owed you to look at
(somehow drowning in mail...) and come back to see that
Jeremy has long pushed it. Apologies...

Thanks Jeremy!
And thanks Rowland for doing the clean patch!

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160107/27d10b41/signature.sig>


More information about the samba-technical mailing list