[PATCH] DRAFT: Add new test which covers force user bug
rhack at redhat.com
Mon Jan 4 13:28:40 UTC 2016
Sorry for such a big delay. I was on vacation. And thank you very much for
I looked at issue which you described and I hope that I fixed it.
In previous case I used $unix_gids for $unix_name user.
I use newly generated gid now.
Could you please check and review my changes again and test them? I ran
$ make test TESTS=samba3.local.nss
and issue seems gone. I'm not sure if other issues will not raise.
Sorry for issues with my patch. I didn't realized how fragile it can be :(.
Have nice day
On Thu, Dec 10, 2015 at 1:18 AM, Jeremy Allison <jra at samba.org> wrote:
> On Wed, Dec 09, 2015 at 11:29:28AM -0800, Jeremy Allison wrote:
> > On Tue, Dec 08, 2015 at 04:50:33PM +0100, Robin Hack wrote:
> > > Hi Andrew.
> > >
> > > Thank you for your time.
> > >
> > > New patch is attached.
> > Pushed to master. Thanks a *LOT* Robin. Helping
> > improve our tests is a thankless task and we're
> > really glad to have you help us with it !
> Spoke too soon :-(. Robin, your patch
> breaks the test:
> make test TESTS=samba3.local.nss
> Fails with:
> WARNING!: ../source4/torture/local/nss_tests.c:589: g1->gr_name was jra,
> expected jra-group: getgrent_r and getgrgid_r gave different results
> WARNING!: ../source4/torture/local/nss_tests.c:679: Expression
> `torture_assert_group_equal(tctx, &grp[i], &grp2, "getgrent_r and
> getgrgid_r gave different results")' failed:
> Which I think is because of the addition
> of the hunk:
> @@ -1552,6 +1580,7 @@
> print GROUP "nobody:x:$gid_nobody:
> in your patch. Can you investigate and
> fix please ?
More information about the samba-technical