[PATCH] lib/util/util.c: move null-check before use

Ralph Boehme rb at sernet.de
Mon Feb 29 21:20:46 UTC 2016


On Mon, Feb 29, 2016 at 01:09:51PM -0800, Jeremy Allison wrote:
> On Thu, Feb 25, 2016 at 05:06:41PM +0100, Aurélien Aptel wrote:
> > Hi,
> > 
> > This patch moves the null pointer check *before* the pointer is used in
> > the strlen() call.
> >     
> > - still allocate the `fname` array on the stack
> > - still compiles under C90 definition/code mixing rules
> > 
> > Please review&push
> 
> Ping ! Can I get a second Team reviewer for this ?

lgtm! Please push. Thanks!

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de



More information about the samba-technical mailing list