[PATCH] Enhance time sampling of async IO VFS functions

[Ralph Boehme]

On Mon, Feb 29, 2016 at 08:50:57AM -0800, Jeremy Allison wrote:
> On Mon, Feb 29, 2016 at 05:26:34PM +0100, Ralph Boehme wrote:
> > On Sun, Feb 28, 2016 at 10:45:47AM -0800, Jeremy Allison wrote:
> > > On Sun, Feb 28, 2016 at 05:45:24PM +0100, Volker Lendecke wrote:
> > > > On Sun, Feb 28, 2016 at 08:39:19AM -0800, Jeremy Allison wrote:
> > > > > > Is it theoretically possible to implement this feature without modifying
> > > > > > tevent, just within asys.c? Apologies for not coming up with a polished
> > > > > > proposal mself, but I would like to avoid bloat in such a central
> > > > > > structure if possible.
> > > > > 
> > > > > Sure, if we change the param blocks to the smbd VFS aio
> > > > > calls then we can do it only inside smbd.
> > > > > 
> > > > > I think the question Ralph had is more about if you
> > > > > think this is worthwhile to add as a feature to tevent ?
> > > > > 
> > > > > Or did you just answer that question ? :-) :-).
> > > > 
> > > > Right now we have one case where someone really needs this feature. We
> > > > have many cases that don't. So if there's an elegant way to do this
> > > > without adding 8 bytes to struct tevent_req I'd prefer that.
> > > 
> > > I think that answers the question.
> > > 
> > > Ralph, I'm sorry - but can you re-do this by creating
> > > a 'struct aiocb {... stuff...}' struct for the VFS
> > > calls, so we don't have to keep adding extra params
> > > if we need something new ?
> > 
> > attached. Please review & push if ok. I know this is cumbersome to
> > review, so a big thanks in advance! :)
> 
> I'll review if you promise to review my OPENDIR VFS
> change also :-). Should be in your queue, I sent it
> out late Friday night..

sure! vfs interface change contest: however is first finishing the
review wins, the loser must rebase. :)

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de