[PATCH] Fix strv_addn(), add strv_split()

Martin Schwenke martin at meltin.net
Mon Feb 29 04:32:49 UTC 2016

2 patches attached:

1. Fix strv_addn()

   Well, this is embarrassing!  I added strv_add() last week but it
   doesn't do what it was meant to and actually produces an invalid
   strv.  :-(

   This fixes it and adds some tests for it.

   Given that the patch goes close to a revert, I'm happy with the
   alternative of reverting and adding this anew... but it seems like
   more hassle.

2. Add strv_split() in new file strv_util.[hc] + tests

   I mentioned this to Volker and he wants to keep strv.[hc] small, so
   suggested that a layer on top could go in an extra file, so here it

Clearly (2) depends on (1), since it uses strv_addn().

Please review and maybe push...

peace & happiness,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lib-util-Fix-strv_addn.patch
Type: text/x-patch
Size: 4748 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160229/2828a30a/0001-lib-util-Fix-strv_addn.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lib-util-Add-strv_util.-ch-containing-new-function-s.patch
Type: text/x-patch
Size: 9453 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160229/2828a30a/0002-lib-util-Add-strv_util.-ch-containing-new-function-s.bin>

More information about the samba-technical mailing list