[PATCH] remove outdated TODO comment

Jeremy Allison jra at samba.org
Sun Feb 28 03:57:47 UTC 2016


On Sun, Feb 28, 2016 at 01:52:55AM +0100, Michael Adam wrote:
> attachment...
> 
> On 2016-02-28 at 01:48 +0100, Michael Adam wrote:
> > Review / push appreciated.
> > 
> > Cheers - Michael

Obvious goodness - pushed !

> From 202fb53e321465a614eb4cf69366df270d69e850 Mon Sep 17 00:00:00 2001
> From: Michael Adam <obnox at samba.org>
> Date: Sun, 28 Feb 2016 01:46:47 +0100
> Subject: [PATCH] smbd:smb2_creat: remove outdated TODO comments
> 
> Leases have meanwhile been implemented and the
> TODO has been taken care of.
> 
> Signed-off-by: Michael Adam <obnox at samba.org>
> ---
>  source3/smbd/smb2_create.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/source3/smbd/smb2_create.c b/source3/smbd/smb2_create.c
> index d450c5c..6f01c39 100644
> --- a/source3/smbd/smb2_create.c
> +++ b/source3/smbd/smb2_create.c
> @@ -555,10 +555,6 @@ static struct tevent_req *smbd_smb2_create_send(TALLOC_CTX *mem_ctx,
>  		 * (Note that the cases of an additional dh2q or dh2c blob
>  		 *  which require a different error code, have been treated
>  		 *  above.)
> -		 *
> -		 * TODO:
> -		 * This is only true for the oplock case:
> -		 * For leases, lease request is required additionally.
>  		 */
>  
>  		if (dhnq) {
> @@ -595,10 +591,6 @@ static struct tevent_req *smbd_smb2_create_send(TALLOC_CTX *mem_ctx,
>  		 * (Note that the cases of an additional dhnq, dhnc or dh2q
>  		 *  blob which require a different error code, have been
>  		 *  treated above.)
> -		 *
> -		 * TODO:
> -		 * This is only true for the oplock case:
> -		 * For leases, lease request is required additionally!
>  		 */
>  
>  		num_blobs_allowed = 1;
> -- 
> 2.5.0
> 






More information about the samba-technical mailing list