[PATCH] s3/libsmb/clirap2.c: use actual buffer size

[Ira Cooper]

Reviewed-by: Ira Cooper <ira at samba.org>

Push away Jeremy.

-Ira

On Fri, Feb 26, 2016 at 1:34 PM, Jeremy Allison <jra at samba.org> wrote:

> On Fri, Feb 26, 2016 at 11:55:38AM +0100, Aurélien Aptel wrote:
> > Hi,
> >
> > data used to be a stack allocated array but was changed to a heap
> > allocated buffer by commit 95a81a3. Update sizeof(data) to data_size.
> >
> > Please review/comment/push
>
> Obviously correct Aurélien - thanks !
>
> Reviewed-by: Jeremy Allison <jra at samba.org>
>
> Can I get a second Team reviewer for this ?
>
> Jeremy.
>
> > --
> > Aurélien Aptel / SUSE Labs Samba Team
> > GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> > SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> > GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
> > Nürnberg)
>
> > From cfbd549464794dd16a2ad23a2ec03320d38810c6 Mon Sep 17 00:00:00 2001
> > From: Aurelien Aptel <aaptel at suse.com>
> > Date: Thu, 25 Feb 2016 14:39:10 +0100
> > Subject: [PATCH 5/5] s3/libsmb/clirap2.c: use actual buffer size
> >
> > data used to be a stack allocated array but was changed to a heap
> > allocated buffer by commit 95a81a3. Update sizeof(data) to data_size.
> >
> > Signed-off-by: Aurelien Aptel <aaptel at suse.com>
> > ---
> >  source3/libsmb/clirap2.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/source3/libsmb/clirap2.c b/source3/libsmb/clirap2.c
> > index 931bc23..6c49363 100644
> > --- a/source3/libsmb/clirap2.c
> > +++ b/source3/libsmb/clirap2.c
> > @@ -331,7 +331,7 @@ int cli_NetGroupAdd(struct cli_state *cli, struct
> rap_group_info_1 *grinfo)
> >
> >       if (cli_api(cli,
> >             param, sizeof(param), 1024, /* Param, length, maxlen */
> > -           data, soffset, sizeof(data), /* data, length, maxlen */
> > +           data, soffset, data_size, /* data, length, maxlen */
> >             &rparam, &rprcnt,   /* return params, length */
> >             &rdata, &rdrcnt))   /* return data, length */
> >       {
> > --
> > 2.1.4
> >
>
>
>
>
>