[PATCH] VFS - modify rmdir to use const struct smb_filename *

Michael Adam obnox at samba.org
Thu Feb 25 16:34:44 UTC 2016

On 2016-02-25 at 16:56 +0100, Michael Adam wrote:
> On 2016-02-24 at 14:44 -0800, Jeremy Allison wrote:
> > Three patches this time. First two patches fix up mkdir in
> > vfs_ceph and vfs_glusterfs as I missed them last time
> > (I don't normally build with them, sorry).
> Just stumbled across these build issues and came up with
> exactly the same patches. :-)
> Realized you had already sent the patches when I wanted
> to post mine.
> Pushing yours.

Note I did some minor indentation changes to these.
And shortened the 'subject' line to be under 80 chars.

> > Last patch converts SMB_VFS_RMDIR calls to use
> > const struct smb_filename * instead of const char *.
> > 
> > Similar to the previous mkdir changes (except I
> > remembered to fix ceph and gluster this time :-).
> Will try to find some time to look at these later today.

Ok, did it now...

The use or not use of a path helper var to
keep the diff smaller is not fully consistent
across the various touched modules, and also
sometimes the indentation is nicely aligned
with the parentheses, and sometimes it is not,
but so what... Nice patch. ;-)

Pushed to autobuild.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160225/1f9f705d/signature.sig>

More information about the samba-technical mailing list