[PATCH] Fix pwdLastSet behaviour in regards to Windows

[Andrew Bartlett]

On Tue, 2016-02-23 at 07:12 +0100, Stefan Metzmacher wrote:
> Hi Andrew,
> 
> > On Wed, 2016-02-17 at 14:14 +1300, adrianc at catalyst.net.nz wrote:
> > > +           && (!io->n.nt_hash) && (!io->n.lm_hash) && (lm_hash))
> > > {
> > 
> > Just a quick note to the list to say that while most of this patch
> > looks OK (but I need to give it another proper look over), the
> > above
> > line concerns me.
> > 
> > Garming and I will sort this one out when we get some time.
> 
> Please have a look at my tries at
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/
> master4-smart
> 
> It starts with
> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=5834ebda2
> 38448856fc5536ffd120980cd1b7843
> and
> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=78b49053a
> 03f4d255c2854b39b048114262d6f4b
> fixes the above problem.
> 
> Then
> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=15bf89efc
> 1c3fd532e837334e869141cff4eabe3
> is important and used in
> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=239f9ad7e
> 654bf537e18f037d394ffb0034b91ae
> 
> Please avoid changing the existing tests, they should continue to
> work
> as is.

The idea with the test changes (that is, what I asked for) was to split
it up so that it was unit tests covering the same code paths, then new
tests to show the fix.  I think we both agree on the need to be very
careful when changing the tests.  I understand they were run against
Windows 2012R2.

> And we need new tests which just adds a user with a password on the
> ldap_add operation, then pwdLastSet should be non "0" if not
> explicitly
> specified. The new test from Adrian should also be fine.

OK.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba