[PATCH] A few cleanups

[Andrew Bartlett]

On Tue, 2016-02-16 at 18:33 +0100, Michael Adam wrote:
> On 2016-02-16 at 08:59 -0800, Jeremy Allison wrote:
> > On Mon, Feb 15, 2016 at 04:09:23PM +0100, Volker Lendecke wrote:
> > > 
> > > For reference: It is 7b7aa016df35ed7f8388a9df08d66a816adc1bf7.
> > > The
> > > patch I had sent to Jeremy contained a helper variable for
> > > 
> > > if (!asn1_blob(asn1, &blob)) {
> > > 
> > > that did not make it into master. So this is at least
> > > controversial.
> > 
> > I removed it as every other check within the asn1.c file
> > was of the form:
> > 
> >   if (!fn_call()) {
> >     ... error handling...
> >   }
> > 
> > So Volker's change *in that file* stood out like a sore
> > thumb
> 
> s/sore thumb/good example/   ;-)
> 
> > and looked strange (anyone reading through it
> > linearly would have seen a jarring discontinuity in
> > error handling).
> > 
> > Context *matters*.
> 
> Sure. You've got a point there (it's a matter of taste).
> 
> But thought that this inconsistency is generally
> accepted as the consequence of the paradigm of adapting
> to newer coding standards only for added or changed code
> instead of applying sweeping changes to change all the
> existing code (in order to avoid obfuscating history).

I for one would prefer obfuscating history over inconsistency in a
file, as we can always dig into that history if we really have to.

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba





-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160223/01faf387/signature.sig>