smbget's -P option

[Andreas Schneider]

On Sunday 21 February 2016 01:02:29 Christian Ambach wrote:
> Am 19.02.16 um 08:55 schrieb Christian Ambach:
> >> However the tests fail on my box. So I checked with smbclient first.
> > 
> > The test passes on my box and it also passes a private autobuild on
> > sn-devel. Not sure what is happening on your machine.
> 
> I was able to determine the difference between sn-devel and Andreas'
> machine. The problem is located in the popt package we bundle in the
> source tree and make use of if there is no system popt lib (or when
> instructed via configure option). Making use of the configure option, I
> was able to recreate the problem.
> Debian and Ubuntu ship with a version of popt that fixes the problem we
> are hitting in smbget (see
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=217602).
> Patch 7 in the patchset applies the same change to our copy of popt.
> While looking into this, I found another problem with the option parsing
> of smbget that I also included a patch for.
> So some patches in the set need review, the others are included for
> completeness and so they can all be pushed together.

What do you think about the attached patch?


	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-SQ-popt-align-checks.patch
Type: text/x-patch
Size: 2076 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160222/2f5bde72/0001-SQ-popt-align-checks.bin>