[PATCHES] util_sd: Also accept hex input for ALLOW/DENIED (was Re: bug in smbcacls)

Jeremy Allison jra at samba.org
Fri Feb 19 23:31:52 UTC 2016

On Fri, Feb 12, 2016 at 10:14:51AM -0700, Christof Schmitt wrote:
> On Thu, Feb 11, 2016 at 04:25:17PM -0800, Herb Lewis wrote:
> > Looks OK but you should probably also remove the comment
> > /* Only numeric form accepted for flags at present */
> > since parse_ace_flags actually checks for the string values.
> > 
> > Of course this does not allow for octal numbers in any of the
> > fields that the %i would have allowed but that is probably OK.
> Ok, here is the updated patch that also removes the wrong comment. For
> octal input, we would need to explicitly use %o, but i don't see the
> need for that input format.
> Can i push with our reviewed-by?

LGTM - pushed (with wrong comment removed).

More information about the samba-technical mailing list