[PATCH] winbind cleanups

[Michael Adam]

On 2016-02-19 at 08:39 +0100, Volker Lendecke wrote:
> On Thu, Feb 18, 2016 at 09:29:19AM -0800, Jeremy Allison wrote:
> > Please persevere with this - it looks like a really nice
> > optimization (and sorely needed :-) !
> 
> This version now survived an autobuild. There was a bug in sid2gid.

Really impressive improvements!

Not fully reviewed eveything yet,
but on a first pass, this caught
my eye:

> From 3ed39c63cd31e21fbaea76c2eea31f03cc0f9b8f Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Tue, 9 Feb 2016 07:36:13 +0100
> Subject: [PATCH 17/26] libwbclient: Use wbcCtxSidsToUnixIds in wbcCtxSidToGid
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
>  nsswitch/libwbclient/wbc_idmap.c | 33 +++++++++++++--------------------
>  1 file changed, 13 insertions(+), 20 deletions(-)
> 
> diff --git a/nsswitch/libwbclient/wbc_idmap.c b/nsswitch/libwbclient/wbc_idmap.c
> index 88ca11b..5cd082b 100644
> --- a/nsswitch/libwbclient/wbc_idmap.c
> +++ b/nsswitch/libwbclient/wbc_idmap.c
> @@ -43,7 +43,7 @@ wbcErr wbcCtxSidToUid(struct wbcContext *ctx, const struct wbcDomainSid *sid,
>  	}
>  
>  	if ((xid.type == WBC_ID_TYPE_UID) || (xid.type == WBC_ID_TYPE_BOTH)) {
> -		*puid = xid.id.gid;
> +		*puid = xid.id.uid;
>  		wbc_status = WBC_ERR_SUCCESS;
>  	} else {
>  		wbc_status = WBC_ERR_DOMAIN_NOT_FOUND;


Doesn't this hunk belong into a different patch?
Is that by chance the bug that you mentioned above?

Otherwise, it looks great. I'll give it a more
thorough pass later (possibly over the week-end)
without meaning to prevent anyone anyone from
proceeding with pushing.. :-)

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160219/9780aead/signature.sig>