Implement LDAP_CONTROL_NOTIFICATION

Stefan Metzmacher metze at samba.org
Fri Feb 19 10:36:45 UTC 2016


Hi,

> here's also an updated patchset, rebased on master
> after the DLIST_REMOVE() changes.

this is in master now and here's a little fix that
fixes the build with older gcc versions (e.g. on ubuntu 10.04)

Please review and push:-)

Thanks!
metze
-------------- next part --------------
From b12805c8b77e382f1d2ae9180ba14e65bf9837c5 Mon Sep 17 00:00:00 2001
From: Stefan Metzmacher <metze at samba.org>
Date: Fri, 19 Feb 2016 00:29:50 +0100
Subject: [PATCH] s4:dsdb_notification: fix the --picky-developer build with
 gcc 4.4.3

The following warning/error is reported:

[1891/4034] Compiling source4/dsdb/samdb/ldb_modules/dsdb_notification.c
cc1: warnings being treated as errors
../source4/dsdb/samdb/ldb_modules/dsdb_notification.c: In function 'dsdb_notification_filter_search':
../source4/dsdb/samdb/ldb_modules/dsdb_notification.c:192: error: value computed is not used
Waf: Leaving directory `/memdisk/autobuild/fl/b300949/samba/bin'
Build failed:  -> task failed (err #1):
	{task: cc dsdb_notification.c -> dsdb_notification_84.o}

Signed-off-by: Stefan Metzmacher <metze at samba.org>
---
 source4/dsdb/samdb/ldb_modules/dsdb_notification.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source4/dsdb/samdb/ldb_modules/dsdb_notification.c b/source4/dsdb/samdb/ldb_modules/dsdb_notification.c
index 02ccc44..19ae9db 100644
--- a/source4/dsdb/samdb/ldb_modules/dsdb_notification.c
+++ b/source4/dsdb/samdb/ldb_modules/dsdb_notification.c
@@ -189,7 +189,7 @@ static int dsdb_notification_filter_search(struct ldb_module *module,
 	down_tree->operation = LDB_OP_GREATER;
 	down_tree->u.equality.attr = "uSNChanged";
 	down_tree->u.equality.value = data_blob_string_const(filter_usn);
-	talloc_move(down_req, &filter_usn);
+	(void)talloc_move(down_req, &filter_usn);
 
 	ret = ldb_build_search_req_ex(&down_req, ldb, req,
 				      req->op.search.base,
-- 
1.9.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160219/5d1f67d6/signature.sig>


More information about the samba-technical mailing list