smbget's -P option

Andreas Schneider asn at samba.org
Thu Feb 18 09:18:39 UTC 2016


On Thursday 18 February 2016 01:09:20 Christian Ambach wrote:
> Am 16.02.16 um 08:26 schrieb Andreas Schneider:
> >> So before spending more time fixing the issues with the option, I would
> >> rather tend to remove it (as part of the smbget renovation efforts for
> >> 4.4). Data migration (including ACLs) is outside of the scope of this
> >> tool and talking about permissions in the docs creates false
> >> expectations.
> > 
> > I would vote for removing it. If things are not clear and the user doesn't
> > easily understand it it will create more problems than we can resolve with
> > it.
> Okay, then let's remove it.
> The attached patchset contains
> * a few more fixes
> * the removal of the -P option (code and docs)
> * a blackbox test for smbget that achieves 62% line coverage.

Hi Ambi,

I did some cosmetic changes to the first 3 patches. Then I changed the test to 
use absolute paths and remove dangling files (rcfile).

https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/master-smbget

However the tests fail on my box. So I checked with smbclient first.

bin/smbclient //127.0.0.35/smbget -U%

Domain=[SAMBA-TEST] OS=[Windows 6.1] Server=[Samba 4.5.0pre1-DEVELOPERBUILD]
smb: \> ls
  .                                   D        0  Thu Feb 18 10:11:46 2016
  ..                                  D        0  Thu Feb 18 09:59:31 2016
  testfile                            N   131072  Thu Feb 18 10:11:48 2016
  dir1                                D        0  Thu Feb 18 10:11:46 2016
  dir2                                D        0  Thu Feb 18 10:11:46 2016

                708113408 blocks of size 1024. 82814640 blocks available
smb: \> get testfile 
getting file \testfile of size 131072 as testfile (42665,3 KiloBytes/sec) 
(average 42666,7 KiloBytes/sec)
asn at fileserver:~/workspace/projects/samba> rm testfile 
asn at fileserver:~/workspace/projects/samba> bin/smbget -v -a 
smb://127.0.0.35/smbget/testfile
Downloaded 0b in 0 seconds


Cheers,


	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list