[PATCH] Address another obvious memory leak in loadparm.
jra at samba.org
Wed Feb 17 17:29:49 UTC 2016
On Wed, Feb 17, 2016 at 11:22:09AM +0100, Andreas Schneider wrote:
> On Wednesday 17 February 2016 08:47:43 Volker Lendecke wrote:
> > On Wed, Feb 17, 2016 at 12:18:09AM +0000, Hemanth Thummala wrote:
> > > I have attached the patch which has the fix for this
> > > problem. Please let me know if the patch looks good.
> > Yes, the patch looks very good, thanks! I haven't run a private autobuild
> > with that yet. Does that survive?
> > Attached find two cosmetic changes. Feel free to squash them.
> > Also, your change triggers the question -- do we have a proper talloc
> > hierarchy for "struct loadparm_service"? If so, couldn't we avoid the
> > special handling in free_service()?
> We also need to backport this, so please open a bug report and add it to the
> commit message. Check "git log v4-4-test" for the format ...
Bug was already logged and added to the commit message:
Patch (and extra cleanups) LGTM. Pushing after local
More information about the samba-technical