[PATCH] Fix 2 Coverity findings
martin at meltin.net
Tue Feb 16 12:23:33 UTC 2016
On Tue, 16 Feb 2016 11:28:49 +0100, Volker Lendecke
<Volker.Lendecke at SerNet.DE> wrote:
> Review appreciated!
OK, it took me a little while to get my head around this one. There
used to be a level of indirection there and now it is gone. So now I'm
taking the address of something and checking that it is non-NULL. Yeah,
that's a bit stupid. :-)
Hmmm... instead you're checking that the pointer to the array can't be
NULL. That can never happen in the current code (famous last words!),
but it seems like a reasonable improvement.
However, I was confused by the combination of the improvement and
removal of the useless code. It could be clearer as 2 separate patches.
Reviewed-by: Martin Schwenke <martin at meltin.net>
Please push with something else? Bed time... at least I understand
it now and it won't keep me awake... :-)
peace & happiness,
More information about the samba-technical