[PATCH] pytalloc and pidl changes for refcounting and incorrect msDS-IntID handling

[Andrew Bartlett]

On Wed, 2016-01-06 at 13:10 +1300, Andrew Bartlett wrote:
> 
> Thanks.  I also have had a failure that indicates our python
> reference
> counting issue may be biting us again.  I'm looking into that.
> 
> Andrew Bartlett

The attached patches appear to address the segfaults by sorting out our
reference handling - we need to track both the talloc context of the
Samba object and the reference handle used by python.

I even have tests to show we are handling the references correctly!

This all seems fairly sane, until you realise that pytalloc.h is a
PUBLIC header.  I've tried some things to fix that, but none of it is
easy, or even practical, so I'm posting this to the list to seek
advice.  

Is it reasonable to make an ABI break on pytalloc.h without changing
the talloc major version?

The remainder of replMetaData-attid has been updated to use this fix,
and appears to be working now. 

http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/r
eplMetaData-attid

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba





-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-pydsdb-Do-not-call-py_return_ndr_struct-on-ldb.Messa.patch
Type: text/x-patch
Size: 2917 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160216/6ca257a2/0001-pydsdb-Do-not-call-py_return_ndr_struct-on-ldb.Messa.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-pidl-Fix-our-python-reference-handling.patch
Type: text/x-patch
Size: 12184 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160216/6ca257a2/0002-pidl-Fix-our-python-reference-handling.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-talloc-Bump-version-number.patch
Type: text/x-patch
Size: 1403 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160216/6ca257a2/0003-talloc-Bump-version-number.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160216/6ca257a2/signature.sig>