[PATCH] param: Fix str_list_v3 to accept ; again

Andrew Bartlett abartlet at samba.org
Mon Feb 15 21:47:04 UTC 2016


On Fri, 2016-02-12 at 07:03 +0100, Volker Lendecke wrote:
> On Fri, Feb 12, 2016 at 02:54:28PM +1300, Andrew Bartlett wrote:
> > This was bothering me, so I finally dug up the root cause of the
> > divergence here.
> 
> Why did Tridge not port this forward to the production version of
> Samba? This has diverged more than 10 (!!) years ago, but he did not
> bother to do this in a more organized and documented manner. Just
> slipping it in without any warning will lead to exactly what
> happened:
> A customer of mine had a major outage after an upgrade. Our include
> paths are a bit complex to figure out, so we can not rely on
> #including
> the LIST_SEP under changes.

I agree that isn't a good outcome.  Can you please add a test to ensure
this does not regress in the future?

Thanks!

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba









More information about the samba-technical mailing list