[PATCH] A few cleanups

Ralph Boehme slow at samba.org
Mon Feb 15 15:15:39 UTC 2016


On Mon, Feb 15, 2016 at 04:13:15PM +0100, Andreas Schneider wrote:
> On Monday 15 February 2016 16:05:44 Ralph Boehme wrote:
> > On Mon, Feb 15, 2016 at 03:59:56PM +0100, Andreas Schneider wrote:
> > > On Monday 15 February 2016 15:56:21 Volker Lendecke wrote:
> > > > On Mon, Feb 15, 2016 at 03:34:41PM +0100, Andreas Schneider wrote:
> > > > >     bool ok;
> > > > >     
> > > > >     ok = ads_pull_uint32(ctx->ads, msg_internal, ...
> > > > >     if (ok) {
> > > > 
> > > > Last time I did this Jeremy took this pattern out of a patch of mine
> > > > before pushing, so I think this is not appropriate upstream anymore.
> > > > 
> > > > Can we clarify this topic once and for all?
> > > 
> > > I've proposed a patch to README.Coding for this.
> > 
> > excellent! But can we please use "result" instead of rc, rv, ret etc.?
> 
> Hmm. We use "result" mostly for WERROR return codes and "rc" or "ret" if it is 
> an integer.
> 
> git grep "WERROR result" 
> git grep "int rc" 

it's a mess:

$ git grep "int ret" | wc -l
3536
$ git grep "int rc" | wc -l
323
$ git grep "int rv" | wc -l
29
$ git grep "int result" | wc -l
310

Cheerio!
-slow



More information about the samba-technical mailing list