[PATCH] A few cleanups

Andreas Schneider asn at samba.org
Mon Feb 15 14:34:41 UTC 2016


On Monday 15 February 2016 12:31:11 Volker Lendecke wrote:
> Hi!
> 
> Review appreciated!

Hi Volker,

can I ask for a view cosmetic changes here?

    if (p_gid) {

to

    if (p_gid != NULL) {

and

    if (ads_pull_uint32(ctx->ads, msg_internal, ...

to

    bool ok;

    ok = ads_pull_uint32(ctx->ads, msg_internal, ...
    if (ok) {


The rest RB+.

Thanks,


	-- andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list