The plan for eliminating lp_posix_pathnames()

Jeremy Allison jra at samba.org
Fri Feb 12 16:49:38 UTC 2016


On Fri, Feb 12, 2016 at 10:42:47AM +0100, Ralph Boehme wrote:
> On Thu, Feb 11, 2016 at 04:45:46PM -0800, Jeremy Allison wrote:
> > Just in case you wondered what I was up to with
> > this :-).
> > 
> > Currently my plan is to move to using
> > const struct smb_filename * instead of const char *
> > on more of the VFS interfaces (such as
> > get_nt_acl_fn(), mkdir, rmdir, rename etc.)
> > 
> > Once this is plumbed through the VFS I
> > think the best idea is to add a bool posix_pathnames
> > to the struct smb_filename, which gets set
> > from the toplevel parse of the incoming
> > client SMB1/SMB2 request.
> 
> shouldn't we use uint64_t posix_flags instead like what we added to
> files_struct for exactly the same purpose iirc?

Sure, we could use a flags field instead of a bool. I can't
think of any other flags that might be useful
here, but it probably wouldn't hurt.



More information about the samba-technical mailing list