[PATCH] param: Fix str_list_v3 to accept ; again
abartlet at samba.org
Fri Feb 12 01:54:28 UTC 2016
On Fri, 2016-02-12 at 14:24 +1300, Andrew Bartlett wrote:
> On Thu, 2016-02-11 at 13:19 +0100, Volker Lendecke wrote:
> > Hi!
> > Review&push appreciated!
> > Thanks, Volker
> Isn't the correct fix just to fix LIST_SEP and move the duplicate out
> of local.h?
> I can't see any users of LIST_SEP that would care, other than
> str_list_make(), and I can't see any callers of str_list_make() that
> use the default and would care. Indeed it would avoid some further
This was bothering me, so I finally dug up the root cause of the
Author: Andrew Tridgell <tridge at samba.org>
Date: Sun Feb 6 08:16:18 2005 +0000
r5249: don't include ';' in the default list separators for parsing
smb.conf. It was rarely (if ever?) used, and poses problems as it
not multi-byte safe for character searches
(This used to be commit 75a6cfb2f6b4ef85cf7e49958cccae9d35c4e5a2)
diff --git a/source4/include/local.h b/source4/include/local.h
index 7723e6c..ae17f57 100644
@@ -47,7 +47,7 @@
#define MAX_PASS_LEN 200
/* separators for lists */
-#define LIST_SEP " \t,;\n\r"
+#define LIST_SEP " \t,\n\r"
/* wchar separators for lists */
#define LIST_SEP_W wchar_list_sep
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
More information about the samba-technical