[PATCH] fix cid 1350009

Uri Simchoni uri at samba.org
Wed Feb 10 10:53:10 UTC 2016

On 02/10/2016 12:03 PM, Michael Adam wrote:
> On 2016-02-10 at 09:46 +0200, Uri Simchoni wrote:
>> It's better, but having carefully looked at it now, I think you also want to
>> set speed to 0 on all failure paths, or report failure to caller and let it
>> intelligently deal with it.
> Well, I also thought about it.
> Currently the pattern is: only set speed on success.
> Otherwise leave speed untouched. In the current caller
> this means that the default is used.
> Of course we could propagate the error, but it seemed
> the most simple this way.
> What specific problem do you see with the current way?
> Thanks - Michael
a. It's not always the default - it's the last interface's result (it's 
in a loop)
b. I'd say that if the name is too long, don't use that interface. 
Speed:=0 is one way of doing it.

More information about the samba-technical mailing list