[PATCH] selftest: create a temporary client env for net ads test

[Andreas Schneider]

On Wednesday 10 February 2016 10:29:40 Uri Simchoni wrote:
> On 02/10/2016 09:13 AM, Andreas Schneider wrote:
> > On Tuesday 09 February 2016 20:40:18 Uri Simchoni wrote:
> >> Hi,
> >> 
> >> <snip>
> >> The patch creates a new temporary client env, with a random string as
> >> host name, so that except for the AD DC which gets to see an account
> >> added and removed, no other component of the test env is affected by the
> >> test.
> > 
> > Very nice! But shouldn't we handle the hostname and setting the config in
> > 
> > selftest/selftest.pl
> > 
> >   867 »·······} elsif ($option eq "client") {
> > 
> > Do it in the client option or add a new option?
> > 
> > <snip>
> 
> Doing it at the client conf was nacked by abartlet b/c it taints the
> client conf. I suppose we can add yet another conf option. Thing is, we
> need conf per test, and I wouldn't hard-code test-specific stuff in this
> area of the code.
> 
> To be more exact, we need a separate conf, and separate place for tdb's,
> but the socket wrapper stuff can use same channels as the client option.
> Therefore I figured we can use the client conf as a template and create
> a new temporary conf that will not conflict with other envs or confs.
> 
> What do you think?

Feel free to push with my RB+

However we need to rewrite selftest some day. The current mix we have is ugly 
and troublesome ...



	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org