[PATCH] selftest: create a temporary client env for net ads test

Andreas Schneider asn at samba.org
Wed Feb 10 07:13:45 UTC 2016

On Tuesday 09 February 2016 20:40:18 Uri Simchoni wrote:
> Hi,
> Paying a long overdue technical debt, this patch fixes an issue with
> samba4.blackbox.net_ads test, namely that it runs in the ad_member test
> env, and changes the shared secret of the member server while it is
> running. Apparently this didn't break autobuild, but a test should
> ideally test one thing only and in our case - just the join/leave
> functionality, not how a member server survives join/leave while it is
> running.
> The patch creates a new temporary client env, with a random string as
> host name, so that except for the AD DC which gets to see an account
> added and removed, no other component of the test env is affected by the
> test.

Very nice! But shouldn't we handle the hostname and setting the config in


 867 »·······} elsif ($option eq "client") {

Do it in the client option or add a new option?

We have the problem that we taint environments in Samba and never throw them 
away. We had failing tests cause of this and the issues are hard to detect.


	-- andreas

Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list