[PATCH] Patch for bug 11714: Listening for network interface changes doesn't work
Amitay Isaacs
amitay at gmail.com
Wed Feb 10 00:46:07 UTC 2016
On Mon, Feb 8, 2016 at 6:13 PM, Ralph Boehme <rb at sernet.de> wrote:
> Hi!
>
> updated patchset with another typo fixed (s/usign/using).
>
> Please review & push if ok. Thanks!
>
> -Ralph
>
>
Hi Ralph,
In the following hunk, may be move result variable in the #ifdef block?
@@ -1395,6 +1438,11 @@ int _tdgram_bsd_existing_socket(TALLOC_CTX *mem_ctx,
{
struct tdgram_context *dgram;
struct tdgram_bsd *bsds;
+ int result;
+#ifdef HAVE_LINUX_RTNETLINK_H
+ struct sockaddr sa;
+ socklen_t sa_len = sizeof(struct sockaddr);
+#endif
dgram = tdgram_context_create(mem_ctx,
&tdgram_bsd_ops,
Otherwise it looks fine. Reviewed by me.
Amitay.
More information about the samba-technical
mailing list