[PATCH] Fix ETIME handling for Solaris event ports

Ralph Boehme rb at sernet.de
Fri Feb 5 20:03:51 UTC 2016


Hi!

On Fri, Feb 05, 2016 at 02:46:48PM -0800, Jeremy Allison wrote:
> On Fri, Feb 05, 2016 at 02:11:44PM -0700, Nathan Huff wrote:
> > Here is a minimized version of the patch.  I also removed the check for
> > tvalp on ETIME since I believe ETIME => tvalp.
> > 
> > 2016-02-05 4:23 GMT-07:00 Ralph Boehme <rb at sernet.de>:
> 
> OK, I'm good with this version and it's close
> to Metze's minimal diff requirement.
> 
> I don't think we need the errno = 0 as nothing
> depends on this in this function, and there's
> no guarentee on errno coming out of this function
> (we might make many other system calls). So -
> 
> Reviewed-by: Jeremy Allison <jra at samba.org>
> 
> Ralph and Metze, are you OK with this version ?

rb: me, but can we possibly push with this whitespace fix:

-		if(nget == 0) {
+		if (nget == 0) {

Thanks!
-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de



More information about the samba-technical mailing list