[PATCH] s3:smbd:open: Skip redundant call to file_set_dosmode when creating a new file.

Scott Lovenberg scott.lovenberg at gmail.com
Thu Feb 4 14:03:49 UTC 2016

On Thu, Feb 4, 2016 at 7:01 AM, José A. Rivera <jarrpa at samba.org> wrote:
> Hey folks,
> The initial patch was failing some autobuild tests. Turns out we should
> probably not skip file_set_dosmode if we still need to set the
> EA. :) However, we only need to worry about fixing the archive bit if the
> file has been overwritten.
> New patch attached. I left "make test" running overnight, and hopefully my
> system wasn't lying this morning when it said ALL OK. :)
> Thanks!
> --Jose

Hah!  I was wondering about exactly that and after looking at the code
I thought that case was taken care of.  The one time I don't ask the
obvious "stupid question"... -1 inquisitive idiot points for me.  Good
thing I've got some stocked up. ;)

Peace and Blessings,

More information about the samba-technical mailing list