[PATCH] Fix ETIME handling for Solaris event ports

Ralph Boehme rb at sernet.de
Wed Feb 3 18:45:52 UTC 2016


On Wed, Feb 03, 2016 at 11:19:49AM -0700, Nathan Huff wrote:
> I am not actually sure if you can get events on EINTR or not and I am not
> sure if anybody else is really sure either.

:)

> I went through and looked what gets handled by other event libraries
> like libevent and libev.  Some of them only treat ETIME specially
> and some of them also check EINTR as well.  I have actually seen the
> ETIME case and could get it to reproduce by running wbinfo -p in a
> tight loop.  I can update the patch to also check on EINTR which
> shouldn't actually hurt anything even if we never get events.

yes please! Can you also submit your patch as git format-patch and add
your signed-off [1]? Thanks!

-Ralph

[1] <https://wiki.samba.org/index.php/CodeReview#commit_message_tags>


-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de



More information about the samba-technical mailing list