[PATCH] fix cid 1350009

Michael Adam obnox at samba.org
Wed Feb 3 13:18:29 UTC 2016


On 2016-02-03 at 14:57 +0200, Uri Simchoni wrote:
> I think we do unnecessarily cut the device name, see for example:
> http://lxr.free-electrons.com/source/net/core/dev.c#L723

Hmm, ok, but as I wrote in the other mail,
ethtool exits with an error if the specified
interface name is of strlen IF_NAMESIZE (or longer).

> But even if we stay with the decision to cut device name (so that we
> don't have to look it up in kernel source..), the cutting is
> incorrect - it's one past array boundary!

Oh, indeed. *brownpaperbag*...

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160203/eee65668/signature.sig>


More information about the samba-technical mailing list