[PATCH] fix cid 1350009

[Volker Lendecke]

On Wed, Feb 03, 2016 at 11:43:07AM +0100, Michael Adam wrote:
> Review/push appreciated.
> 
> Thanks - Michael

> From 267367964c957af33c8dded90bb61c009ed29039 Mon Sep 17 00:00:00 2001
> From: Michael Adam <obnox at samba.org>
> Date: Wed, 3 Feb 2016 11:41:23 +0100
> Subject: [PATCH] lib:socket: fix CID 1350009 - illegal memory accesses 
>  (BUFFER_SIZE_WARNING)
> 
> Signed-off-by: Michael Adam <obnox at samba.org>
> ---
>  lib/socket/interfaces.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/socket/interfaces.c b/lib/socket/interfaces.c
> index f0386c0..c1229f2 100644
> --- a/lib/socket/interfaces.c
> +++ b/lib/socket/interfaces.c
> @@ -140,7 +140,8 @@ static void query_iface_speed_from_name(const char *name, uint64_t *speed)
>  		return;
>  	}
>  
> -	strncpy(ifr.ifr_name, name, IF_NAMESIZE);
> +	strncpy(ifr.ifr_name, name, IF_NAMESIZE - 1);
> +	ifr.ifr_name[IF_NAMESIZE] = '\0';

I saw this one, but I was not sure about the expectation of
ioctl(SIOCETHTOOL). Don't we unnecessarily cut the interface name
here?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de