[PATCH] DRAFT: Add new test which covers force user bug

Andreas Schneider asn at samba.org
Mon Feb 1 10:18:36 UTC 2016


On Wednesday 27 January 2016 13:17:04 Uri Simchoni wrote:
> It appears to me that the essence of this new test suite is to perform a
> successful tree-connect to the force_user_valid_users share, using
> $USERNAME/$PASSWORD credentials. Can't it be just added as another test
> to an existing test suite that tests similar things using similar
> techniques? Good candidates are:
> - samba3.blackbox.valid_users
> - samba3.blackbox.smbclient_auth.plain
> 
> (actually I think the two test suites should be merged, or that all
> "force user" test should be combined in a separate test suite, where it
> can be verified not only that the tree-connect succeeds, but also that
> the force-user works, e.g. by creating a file and doing smbcacls on it -
> but that can be done later. In the meantime I don't see a reason for
> adding another test suite)

I think we should move all 'force user' test to a new test. Could we push the 
patch upstream and then work on merging them?


	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list