[PATCH] Python3 compatible modules - credentials, param, _glue
lbalhar at redhat.com
Thu Dec 22 13:34:20 UTC 2016
On 12/14/2016 08:32 AM, Andrew Bartlett wrote:
> On Tue, 2016-12-13 at 12:08 +0100, Lumir Balhar wrote:
>> The changes in this patchset port the samba.credentials, samba.param
>> samba._glue modules to Python 3 compatible form. This patchset also
>> contains a
>> lot of new tests of mentioned modules. The file compat.py will help
>> with porting and to make the future code more readable.
> Thanks for all the hard work, and for addressing my feedback on the
> exceptions. I guess you could imagine that I'm hoping you can port
> samba._ldb soon, so we can get that PY3 test out of samba/__init__.py.
> I'll give this a closer look as soon as I can.
> Andrew Bartlett
Thank you for starting the review.
I am currently working on the samba._ldb module, but it has a long
dependency line that includes auth, params, a lot of the RPC modules,
and more. Nevertheless, I've managed to port the dependency tree and it
seems to work.
But the next problem I have to solve is tests. The modules mentioned
above have no separate tests for each of them, and to run a more complex
test suites (like the raw test of DCERPC) I need to port more modules
which are included in this complex test suites -- for example NDR.
So, yes, I am working on it and it's progressing well, but it will take
some time to have all the test dependencies prepared and tested as well.
Thank you very much for your cooperation and have a nice day.
More information about the samba-technical