[Patches] libsmb make more usage of cli_credentials

Andrew Bartlett abartlet at samba.org
Mon Dec 19 23:48:01 UTC 2016


On Tue, 2016-12-20 at 00:05 +0100, Stefan Metzmacher wrote:
> Hi,
> 
> here're some patches which make use of the new
> get_cmdline_auth_info_creds() and
> change the SMB1 encryption to use cli_credentials.
> 
> Please review and push:-)
> 
> This depends on the "auth/credentials for user_auth_info"
> patchset.
> 
> Everything is part of my master3-libsmb-ok branch, see
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/
> master3-libsmb-ok

I'm not very confident in the async smb client library, so I would like
you to get a second review from another team member on those parts if
possible before 4.6.

However, I'm also really excited to see this move forward, and I don't
see any major issues.  It is great to see the creds code used
consistently!

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Andrew Bartlett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 862 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161220/172724cf/signature.sig>


More information about the samba-technical mailing list