[PATCH][WIP] Make the Samba AD DC multi-process

Andrew Bartlett abartlet at samba.org
Mon Dec 19 10:36:33 UTC 2016


On Thu, 2016-12-15 at 04:00 +1300, Andrew Bartlett wrote:
> On Wed, 2016-12-14 at 12:08 +0100, Stefan Metzmacher wrote:
>> > I've pushed the torture tests alone as I want to make sure we
> > already
> > pass them (as we should) with the current code.
> 
> Good idea.  I just ran out of work day to re-order, so thanks!
> 
> > 
> > I'd push the "rpc_server:netlogon Move from memcache to a tdb
> > cache"
> > patch with the following additions squashed:
> > https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=7b19da5
> > 51
> > 6a63126cb087403057639cca600fc10
> 
> Thanks.
> 
> > 
> > Then I'll push the "lsa over netlogon" patches alone.
> 
> Great.
> 
> > 
> > I still think we should not handle
> > DCESRV_INTERFACE_FLAGS_HANDLES_NOT_USED
> > in dcesrv_handle_fetch(), if you want to add something
> > let dcesrv_handle_new() fail and make sure all callers
> > of dcesrv_handle_new() check the return.

I've added an SMB_ASSERT() to both calls.  I hope this is an acceptable
approach, otherwise please just ignore this patch, it isn't worth going
over and over again compared to the other things we need to sort out
this week. 

> > And before calling dcesrv_add_ep() we should
> > set e->use_single_process = true if this_model_ops is
> > the same as model_ops. If someone uses samba -Msingle
> > e->use_single_process should always be true.
> 
> OK, that makes a little more sense to me now.  Could you do that for
> me?  (Otherwise I'll get to it next week).

I've added that.  Can you please review the attached, or at least
indicate I've met your objections?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba
-------------- next part --------------
A non-text attachment was scrubbed...
Name: multi-process-samba-ad-dc.patch
Type: text/x-patch
Size: 25746 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161219/850dbc12/multi-process-samba-ad-dc.bin>


More information about the samba-technical mailing list