[PATCH] documentation fixes and keytab handling regression

[Andreas Schneider]

On Wednesday, 14 December 2016 10:53:07 CET jim wrote:
> This isn't correct.
> cmp1 != 0 test is only proper if strncmp(keytab_name_req, "WRFILE:", 7)
> == 0.
> cmp2 != 0 test is only proper if strncmp(keytab_name_req, "FILE:", 5) == 0.
> 
> On 12/14/2016 10:48 AM, Andreas Schneider wrote:
> > +		int cmp1, cmp2;
> > +
> > +		cmp1 = strncmp(keytab_name_req, "WRFILE:/", 8);
> > +		cmp2 = strncmp(keytab_name_req,"FILE:/", 6);
> > +		if (cmp1 != 0 && cmp2 != 0) {
> > +			return KRB5_KT_BADNAME;
> > +		}
> > +
> > 
> >   		if (keytab_name_req[0] != '/') {
> >   		
> >   			return KRB5_KT_BADNAME;
> >   		
> >   		}

Here is a patchset including unit tests written in cmocka. Sadly our autobuild 
host only offers cmocka 0.3.2 which is way too old. The test requires at least 
version 1.0 which has support for subunit output. So it will not run on 
autobuild until we upgrade to a newer version.


Review and push appreciated.


Thanks!


	Andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: krb5samba.patch
Type: text/x-patch
Size: 11201 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161215/6c81591b/krb5samba.bin>