[PATCH] documentation fixes and keytab handling regression

jim jim.brown at rsmas.miami.edu
Wed Dec 14 15:53:07 UTC 2016


This isn't correct.
cmp1 != 0 test is only proper if strncmp(keytab_name_req, "WRFILE:", 7) 
== 0.
cmp2 != 0 test is only proper if strncmp(keytab_name_req, "FILE:", 5) == 0.

On 12/14/2016 10:48 AM, Andreas Schneider wrote:
> +		int cmp1, cmp2;
> +
> +		cmp1 = strncmp(keytab_name_req, "WRFILE:/", 8);
> +		cmp2 = strncmp(keytab_name_req,"FILE:/", 6);
> +		if (cmp1 != 0 && cmp2 != 0) {
> +			return KRB5_KT_BADNAME;
> +		}
> +
>   		if (keytab_name_req[0] != '/') {
>   			return KRB5_KT_BADNAME;
>   		}



More information about the samba-technical mailing list