[PATCH] remove xfile.[ch]
abartlet at samba.org
Mon Dec 12 16:05:42 UTC 2016
On Fri, 2016-12-09 at 14:34 -0800, Jeremy Allison wrote:
> On Fri, Dec 09, 2016 at 09:10:14PM +0100, Volker Lendecke wrote:
> > On Sat, Dec 10, 2016 at 07:41:15AM +1300, Andrew Bartlett wrote:
> > >
> > > On Fri, 2016-12-09 at 14:27 +0100, Volker Lendecke wrote:
> > > >
> > > > Hi!
> > > >
> > > > The attached patchset removes our stdio replacement xfile.[ch].
> > > > I
> > > > haven't been able to test everything, for example I don't have
> > > > AIX
> > > > available, but the small unit tests I've done looked promising.
> > >
> > > Somewhere in the commit messages can you please include a
> > > reference to
> > > the same info I replied with last time, that is Solaris 10
> > > finally
> > > included support for large FDs in FILE?
> > We're already using fopen in other places in Samba too, so to be
> > honest
> > I did not feel the need to justify this. The restriction of stdio
> > to
> > a low number of fd's is just too silly to really think about, at
> > least
> > from my point of view. Unless you show this mentioned somewhere in
> > posix
> > I would just put a silent R.I.P. to it.
> > But on the other hand -- feel free to modify the commit message of
> > the
> > removal patch.
> LGTM. Pushed with an updated commit message on the removal
> patch !
Thanks Jeremy, Volker. That was exactly what I was looking for.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical