[PATCH] remove xfile.[ch]

[Jeremy Allison]

On Sat, Dec 10, 2016 at 01:47:51PM -0800, Jeremy Allison wrote:
> Ah, I think this code has exposed an oooold ooold bug in ntlm_auth.c
> 
> I don't think this:...
> 
> static char winbind_separator(void)
> {
>         struct winbindd_response response;
>         static bool got_sep;
>         static char sep;
> 
>         if (got_sep)
>                 return sep;
> 
>         ZERO_STRUCT(response);
> 
>         /* Send off request */
> 
>         if (winbindd_request_response(NULL, WINBINDD_INFO, NULL, &response) !=
>             NSS_STATUS_SUCCESS) {
>                 d_printf("could not obtain winbind separator!\n");
>                 return *lp_winbind_separator();
>         }
> 
> should be printing to stdout...

OK - new bug:

https://bugzilla.samba.org/show_bug.cgi?id=12467

Bug 12467 - ntlm_auth can corrupt the output stream with spurious error messages.

Here is the fix. With this patch attached Volker's
changes pass the previously failing test.

Please review and push if happy !

Cheers,

Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-ntlm_auth-Don-t-corrupt-the-output-stream-with-de.patch
Type: text/x-diff
Size: 1560 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161210/26d62c52/0001-s3-ntlm_auth-Don-t-corrupt-the-output-stream-with-de.diff>