[PATCH] remove xfile.[ch]

Jeremy Allison jra at samba.org
Sat Dec 10 21:25:27 UTC 2016


On Sat, Dec 10, 2016 at 11:42:17AM -0800, Jeremy Allison wrote:
> On Fri, Dec 09, 2016 at 02:27:01PM +0100, Volker Lendecke wrote:
> > Hi!
> > 
> > The attached patchset removes our stdio replacement xfile.[ch]. I
> > haven't been able to test everything, for example I don't have AIX
> > available, but the small unit tests I've done looked promising.
> > 
> > Review appreciated!
> 
> FYI. I'm trying to push this because it's obviously correct :-),
> but with this patchset I repeatably get with:
> 
> make test TESTS=samba3.ntlm_auth
> 
> the following:
> 
> [1(0)/2 at 0s] samba3.ntlm_auth.krb5 with old ccache(ktest:local)
> UNEXPECTED(failure): samba3.ntlm_auth.krb5 with old ccache(ktest:local).ntlm_auth with krb5 gss-spnego-client and gss-spnego server(ktest:local)
> REASON: Exception: Exception: could not obtain winbind domain name!
> could not obtain winbind netbios name!
> could not obtain winbind domain name!
> command: /home/jeremy/src/samba/git/master/source3/script/tests/test_ntlm_auth_krb5.sh python /home/jeremy/src/samba/git/master/source3 /home/jeremy/src/samba/git/m
> expanded command: /home/jeremy/src/samba/git/master/source3/script/tests/test_ntlm_auth_krb5.sh python /home/jeremy/src/samba/git/master/source3 /home/jeremy/src/sa
> ERROR: Testsuite[samba3.ntlm_auth.krb5 with old ccache(ktest:local)]
> REASON: Exit code was 1
> 
> which is driving me *nuts*, because there's absolutely
> no reason for it :-).
> 
> Still investigating..

OK, I'm getting close. I think ntlm_auth is failing to return a '\n' somewhere.
Still investigating. God I *HATE* debugging python code :-).



More information about the samba-technical mailing list