[PATCH] remove xfile.[ch]
jra at samba.org
Fri Dec 9 22:34:50 UTC 2016
On Fri, Dec 09, 2016 at 09:10:14PM +0100, Volker Lendecke wrote:
> On Sat, Dec 10, 2016 at 07:41:15AM +1300, Andrew Bartlett wrote:
> > On Fri, 2016-12-09 at 14:27 +0100, Volker Lendecke wrote:
> > > Hi!
> > >
> > > The attached patchset removes our stdio replacement xfile.[ch]. I
> > > haven't been able to test everything, for example I don't have AIX
> > > available, but the small unit tests I've done looked promising.
> > Somewhere in the commit messages can you please include a reference to
> > the same info I replied with last time, that is Solaris 10 finally
> > included support for large FDs in FILE?
> We're already using fopen in other places in Samba too, so to be honest
> I did not feel the need to justify this. The restriction of stdio to
> a low number of fd's is just too silly to really think about, at least
> from my point of view. Unless you show this mentioned somewhere in posix
> I would just put a silent R.I.P. to it.
> But on the other hand -- feel free to modify the commit message of the
> removal patch.
LGTM. Pushed with an updated commit message on the removal
More information about the samba-technical