[PATCH] remove xfile.[ch]

Andrew Bartlett abartlet at samba.org
Fri Dec 9 18:41:15 UTC 2016

On Fri, 2016-12-09 at 14:27 +0100, Volker Lendecke wrote:
> Hi!
> The attached patchset removes our stdio replacement xfile.[ch]. I
> haven't been able to test everything, for example I don't have AIX
> available, but the small unit tests I've done looked promising.

Somewhere in the commit messages can you please include a reference to
the same info I replied with last time, that is Solaris 10 finally
included support for large FDs in FILE?  

It will help some poor person doing software archaeology in the future
greatly if you could also include a little rationale for why you want
to make the change.  I think we here now, knowing you, can make some
educated guesses around not wanting to un-avoidably duplicate libc in
Samba, but that context will be lost.

See my attempts to remove //pipe/netlogon from lsarpc for a good
example where I sorely wish I had written just two more sentences a
decade ago. :-)


> Review appreciated!
> Thanks, Volker
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list