[PATCH] Internal DNS, RPC server & samba-tool tests & fixes

Andrew Bartlett abartlet at samba.org
Thu Dec 8 22:20:18 UTC 2016

On Fri, 2016-12-09 at 10:44 +1300, Bob Campbell wrote:
> Hi,
> Here are a bunch of patches to test "samba-tool dns", extend testing
> for
> DNS over RPC directly, and fix some problems found through the tests.

G'Day Bob,

I'm really impressed with this patch series.  It covers a really
important hole in our testing, and makes the tool much more reliable!

I love that you add the tests, then how that the fixes fix the tests by
removing the knownfail again. 

A few nitpicks:
[PATCH 02/12] python/tests: add tests for samba-tool dns
 - Don't use DC_SERVER, use SERVER to find the server (so we can aim
the test at the non-primary server and have it actually use that
[PATCH 07/12] dnsserver: add dns name checking
 - Don't use // comments (against our coding style)

Other than that: Reviewed-by: Andrew Bartlett <abartlet at samba.org>


Andrew Bartlett

More information about the samba-technical mailing list