[PATCH][WIP] Make the Samba AD DC multi-process

[Stefan Metzmacher]

Am 08.12.2016 um 06:39 schrieb Andrew Bartlett:
> Just a quick update on the easier parts:
> 
> On Thu, 2016-12-08 at 07:26 +1300, Andrew Bartlett wrote:
>> On Wed, 2016-12-07 at 13:09 +0100, Stefan Metzmacher wrote:
>>> Hi Andrew,
>>>
>>>>
>>>> Do you have any other comments?  Is the general approach OK?
>>>>
>>>> Can I merge more of the RPC code, like the 'uses handles'
>>>> declaration?
>>>
>>> Do you have a rebased branch somewhere?
> 
> git://git.catalyst.net.nz/samba.git multi-process-samba-ad-dc

I've pushed the pidl and mgmt change. Can you please
rebase the conflict resolution should be trivial.

>>> Regarding the are_handles_used please make it an
>>> uint64_t flags (with DCESRV_IGNORE_INVALID_ASSOC_GROUP)
>>> and move it to the end of the structure.

Can we get a DCESRV_IGNORE_INVALID_ASSOC_GROUP
instead of DCESRV_INTERFACE_FLAGS_HANDLES_USED?

And the .c file should set a

#define DCESRV_INTERFACE_NETLOGON_FLAGS DCESRV_IGNORE_INVALID_ASSOC_GROUP

The assoc_group == NULL should not move please use
the DCESRV_IGNORE_INVALID_ASSOC_GROUP indication on the
endpoint above the existing check.

Regarding the schannel change shouldn't we try to remove unused
records?

More comments tomorrow.

metze


>> Sure.
> 
> Done.  
> 
> Andrew Bartlett
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161208/b410fdae/signature.sig>