[PATCH] Fix routine description of dbghdrclass

[Michael Adam]

Can we get a second team reviewer, please?

Thanks - Michael

On 2016-12-07 at 01:34 +0100, Michael Adam wrote:
> Reviewed-by: me.
> 
> Michael
> 
> On 2016-12-06 at 15:41 +0530, Anoop C S wrote:
> > Hi,
> > 
> > 
> > Please review the attached patch set which fixes the description for routine dbghdrclass().
> > 
> > Thanks,
> > --Anoop C S. 
> 
> > From e90234b720534c6341be90b49ebc89d5ad653449 Mon Sep 17 00:00:00 2001
> > From: Anoop C S <anoopcs at redhat.com>
> > Date: Tue, 6 Dec 2016 15:20:51 +0530
> > Subject: [PATCH 1/2] lib/util: Fix input arguments description for
> >  dbghdrclass() routine
> > 
> > Signed-off-by: Anoop C S <anoopcs at redhat.com>
> > ---
> >  lib/util/debug.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/lib/util/debug.c b/lib/util/debug.c
> > index 99b1584..113438f 100644
> > --- a/lib/util/debug.c
> > +++ b/lib/util/debug.c
> > @@ -1215,14 +1215,12 @@ void dbgflush( void )
> >   Input:  level - Debug level of the message (not the system-wide debug
> >                    level. )
> >  	  cls   - Debuglevel class of the calling module.
> > -          file  - Pointer to a string containing the name of the file
> > +          location  - Pointer to a string containing the name of the file
> >                    from which this function was called, or an empty string
> >                    if the __FILE__ macro is not implemented.
> >            func  - Pointer to a string containing the name of the function
> >                    from which this function was called, or an empty string
> >                    if the __FUNCTION__ macro is not implemented.
> > -         line  - line number of the call to dbghdr, assuming __LINE__
> > -                 works.
> >  
> >    Output: Always true.  This makes it easy to fudge a call to dbghdr()
> >            in a macro, since the function can be called as part of a test.
> > -- 
> > 2.9.3
> > 
> > From 37ed61b8d5d7908bb4c22da27582cfe5c3a48853 Mon Sep 17 00:00:00 2001
> > From: Anoop C S <anoopcs at redhat.com>
> > Date: Tue, 6 Dec 2016 15:25:46 +0530
> > Subject: [PATCH 2/2] lib/util: Fix indentation within routine description for
> >  dbghdrclass
> > 
> > Signed-off-by: Anoop C S <anoopcs at redhat.com>
> > ---
> >  lib/util/debug.c | 30 +++++++++++++++---------------
> >  1 file changed, 15 insertions(+), 15 deletions(-)
> > 
> > diff --git a/lib/util/debug.c b/lib/util/debug.c
> > index 113438f..37582db 100644
> > --- a/lib/util/debug.c
> > +++ b/lib/util/debug.c
> > @@ -1212,21 +1212,21 @@ void dbgflush( void )
> >  /***************************************************************************
> >   Print a Debug Header.
> >  
> > - Input:  level - Debug level of the message (not the system-wide debug
> > -                  level. )
> > -	  cls   - Debuglevel class of the calling module.
> > -          location  - Pointer to a string containing the name of the file
> > -                  from which this function was called, or an empty string
> > -                  if the __FILE__ macro is not implemented.
> > -          func  - Pointer to a string containing the name of the function
> > -                  from which this function was called, or an empty string
> > -                  if the __FUNCTION__ macro is not implemented.
> > -
> > -  Output: Always true.  This makes it easy to fudge a call to dbghdr()
> > -          in a macro, since the function can be called as part of a test.
> > -          Eg: ( (level <= DEBUGLEVEL) && (dbghdr(level,"",line)) )
> > -
> > -  Notes:  This function takes care of setting current_msg_level.
> > + Input:  level    - Debug level of the message (not the system-wide debug
> > +                    level. )
> > +         cls      - Debuglevel class of the calling module.
> > +         location - Pointer to a string containing the name of the file
> > +                    from which this function was called, or an empty string
> > +                    if the __FILE__ macro is not implemented.
> > +         func     - Pointer to a string containing the name of the function
> > +                    from which this function was called, or an empty string
> > +                    if the __FUNCTION__ macro is not implemented.
> > +
> > + Output: Always true.  This makes it easy to fudge a call to dbghdr()
> > +         in a macro, since the function can be called as part of a test.
> > +         Eg: ( (level <= DEBUGLEVEL) && (dbghdr(level,"",line)) )
> > +
> > + Notes:  This function takes care of setting current_msg_level.
> >  
> >  ****************************************************************************/
> >  
> > -- 
> > 2.9.3
> > 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161208/8c6158c7/signature.sig>