[PATCH] Fix missing permission check on destination directory on rename.

Jeremy Allison jra at samba.org
Wed Dec 7 19:21:06 UTC 2016

On Wed, Dec 07, 2016 at 08:18:24AM +0100, Volker Lendecke wrote:
> On Tue, Dec 06, 2016 at 09:51:05AM -0800, Jeremy Allison wrote:
> > Bit of a corner case, took me a while to code
> > up a good regression test case, but fixes an
> > issue if there is a missmatch between the
> > underlying file system permissions and the
> > stored NT ACLs.
> Just for my understanding -- wasn't the idea that Posix always rules?
> If someone changes the file system acl, our getacl code will override
> the nt acl, due to a checksum mismatch?

Yes it does - that's why I had to do the test on a
share set with 'ignore system acls' set - it took
me a while to get a test that the original code
actually fails because of this :-).

> The code of course looks good, the test case is an interesting sample :-)

Thanks !

More information about the samba-technical mailing list