[PATCH] Fix missing permission check on destination directory on rename.

Michael Adam obnox at samba.org
Wed Dec 7 07:23:17 UTC 2016


On 2016-12-07 at 08:18 +0100, Volker Lendecke wrote:
> On Tue, Dec 06, 2016 at 09:51:05AM -0800, Jeremy Allison wrote:
> > Bit of a corner case, took me a while to code
> > up a good regression test case, but fixes an
> > issue if there is a missmatch between the
> > underlying file system permissions and the
> > stored NT ACLs.
> 
> Just for my understanding -- wasn't the idea that Posix always rules?
> If someone changes the file system acl, our getacl code will override
> the nt acl, due to a checksum mismatch?

Correct.
Except for the case when "acl_xattr:ignore system acls = true"
in smb.conf.

Michael


> The code of course looks good, the test case is an interesting sample :-)
> 
> Volker
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161207/ec278936/signature.sig>


More information about the samba-technical mailing list