ctdb reclock API for etcd/librados
ddiss at suse.de
Tue Dec 6 13:34:44 UTC 2016
On Tue, 6 Dec 2016 18:24:30 +1100, Amitay Isaacs wrote:
> Sorry for not responding earlier. NACK on this patch.
> This is incomplete patch. Anything that is not required for core operation
> does not belong in ctdb/tools.
> - This code and doc belongs in ctdb/utils/etcd.
> - This should be installed only with --enable-etcd (or such option).
I don't think these concerns warrant a revert. The attached patch-set
moves the code (not the doc) to ctdb/utils/etcd, and adds a new
--enable-etcd-reclock configure switch. Would this be sufficient?
I'd prefer to keep the man page under doc/. We could change the
makefiles to only generate/install if --enable-etcd-reclock is flagged.
More information about the samba-technical