ctdb reclock API for etcd/librados

[Amitay Isaacs]

On Sun, Dec 4, 2016 at 7:39 AM, Martin Schwenke <martin at meltin.net> wrote:

> On Sat, 3 Dec 2016 15:54:06 +0100, David Disseldorp <ddiss at suse.de>
> wrote:
>
> > On Thu, 17 Nov 2016 09:41:47 -0600, José A. Rivera wrote:
> >
> > > See attached. Applies to current (as of this email) master. :)
> >
> > Your patch looks fine to me, it's just missing the following entry in
> > ctdb/doc/Makefile:
> >       ctdb-etcd.7 ctdb-etcd.7.html \
>
> We really should consider getting rid of the nested Makefile, but let's
> not worry about that now.  I can't remember Amitay's thoughts on it...
>
> > Once fixed, feel free to push with:
> > Reviewed-by: David Disseldorp <ddiss at samba.org>
>
> Sorry, I'd been meaning to ask if this was just show-and-tell or for
> posted for inclusion... and then it disappeared into the depths of my
> email.  Good to see it going in...
>
> peace & happiness,
> martin
>
>
Sorry for not responding earlier.  NACK on this patch.

This is incomplete patch.  Anything that is not required for core operation
does not belong in ctdb/tools.

- This code and doc belongs in ctdb/utils/etcd.
- This should be installed only with --enable-etcd (or such option).

Amitay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Revert-ctdb-Add-new-helper-ctdb_etcd_lock.patch
Type: text/x-patch
Size: 14099 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161206/89c602fc/0001-Revert-ctdb-Add-new-helper-ctdb_etcd_lock.bin>